influxdata/telegraf

Add tests for internal/snmp

Open

#10,531 opened on Jan 27, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Go (9,892 stars) (4,161 forks)batch import
area/snmphelp wantedsize/mtesting request

Description

Feature Request

Opening a feature request kicks off a discussion.

Proposal:

Add tests for internal/snmp package:

  • ClearCache
  • GetIndex
  • LoadMibsFromPath #10551
  • NewWrapper
  • SetAgent
  • SnmpTranslateCall
  • TrapLookup #10430

Some of these are already covered by tests in plugin/inputs/snmp, but best is to test them at the correct place.

Current behavior:

Changes in code do change behaviour of some plugins.

Desired behavior:

Tests prevent changes in behaviour to the end-users.

Contributor guide

Tech stack
go
Domain
testing
Issue type
test
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Go programmingunit testing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Start by examining the existing tests in plugin/inputs/snmp to understand the testing patterns used in the project. Then, for each remaining function (ClearCache, GetIndex, NewWrapper, SetAgent, SnmpTranslateCall) in internal/snmp, write corresponding unit tests using the Go testing package. Refer to the linked pull requests #10551 and #10430 for examples of how similar tests were added.