infinitered/nsfwjs

Make @nsfw-filter/gif-frames optional

Open

#554 opened on Oct 23, 2021

View on GitHub
 (7 comments) (1 reaction) (0 assignees)JavaScript (7,090 stars) (507 forks)batch import
enhancementhelp wanted

Description

@nsfw-filter/gif-frames is not only big, but it also depends on cwise-compiler which uses unsafe functions ("new Function"). Ideally it could be made optional--not everyone using the nsfwjs needs/wants gif support.

Contributor guide

Tech stack
javascripttensorflow
Domain
machine learningfrontend
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptnpmunderstanding of optional dependencies
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate how @nsfw filter/gif frames is currently imported in nsfwjs. Look at package.json and the source files that import it. Consider using dynamic imports or a peer dependency to make it optional. The issue comments may contain suggestions. Also check the repository's build configuration to ensure the library can function without the dependency.