infinitered/ignite

Dark mode support in splash-screen generator

Open

#2855 opened on Nov 25, 2024

View on GitHub
 (3 comments) (0 reactions) (2 assignees)TypeScript (16,168 stars) (1,342 forks)batch import
enhancementhelp wanted

Description

I'd like to be able to generate the assets for a dark mode splash screen along side the "normal" light mode assets.

Currently, I can call npx ignite-cli generate splash-screen and the generator will read logo.png from ignite/templates/splash-screen and output the necessary assets to assets/images. That will work whether logo.png is the image I want to use for light mode or dark mode. The trouble is that if I do one it will overwrite the other and vice versa. I'd like to be able to generate both sets of assets at the same time so I can reference them from my expo app.json

I suggest adding a --dark parameter that would tell the generate to read logo-dark.png, output assets that start with "splash-logo-dark" instead of "splash-logo," and update app.json accordingly. But there might be other possible solutions.

I'm happy to take a shot at adding this myself and sending a PR. But I thought it would be wise to make sure something like this wasn't already in the works. And that the solution I suggested above is a valid design.

Thanks!

Contributor guide

Tech stack
typescriptreact nativenodejs
Domain
mobilecli
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
blocked
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic knowledge of React NativeFamiliarity with Ignite CLIUnderstanding of splash screen asset generation
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
The user suggests adding a dark flag to the generate splash screen command. Investigate the current implementation in ignite/templates/splash screen and the corresponding CLI command in the Ignite repository. Review how the generator reads logo.png and outputs assets. Then, consider modifying the command to accept dark, read logo dark.png, and output assets with 'splash logo dark' prefix while updating app.json. Check comments on the issue for any additional requirements or designs.