import-js/eslint-plugin-import

Check for importing named exports from CJS module

Open

#928 opened on Sep 15, 2017

View on GitHub
 (8 comments) (2 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
enhancementhelp wanted

Description

With the new node.js 8.5 ESM support importing CJS modules as if they had named exports is not supported. (Unlike Babel)

Eg:

// bad
import { get } from 'lodash';

//good
import _ from 'lodash';
const get = _.get;

//good
import { get } from 'lodash-es';

Contributor guide

Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint plugin developmentNode.js module systemAST traversal basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Implement a new rule that detects named imports from CommonJS modules. The rule should be placed in the src/rules directory following the pattern of existing rules. Look at similar rules like 'no named as default' for reference. Ensure to handle both static and dynamic imports, and consider the case when the module has an 'esModuleInterop' flag or is a known CJS module like 'lodash'. The issue discussion suggests using the 'resolve' module to check if the imported module is CJS.