import-js/eslint-plugin-import

Request: option to let `no-duplicates` force type & normal imports to be de-duplicated

Open

#909 opened on Aug 4, 2017

View on GitHub
 (9 comments) (5 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
enhancementflowhelp wanted

Description

#225 asked to allow both type & normal imports to be allowed together, e.g.

import {someFunction} from '../src/foo';
import type {someType} from '../src/foo';

This was requested because according to the author there was no way to merge these together at that point in time.

However, currently flow does support merging these imports together:

import { someFunction, type someType } from '../src/foo';

I think it would therefore be useful if no-duplicates could be configured to have the same behaviour as before #225, i.e. to require type & normal imports to be merged.

Contributor guide

Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ESLintUnderstanding of import rules
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Review discussion in #225 and the current no duplicates rule implementation in eslint plugin import/src/rules/no duplicates.js. The maintainers indicated that merging type and normal imports is now supported in Flow, so the rule should update to allow configuration for merging them. Look at how the rule handles type imports and consider adding an option like 'mergeTypeAndNormal'.