import-js/eslint-plugin-import

import/no-unresolved errors if package omits `.js` extension in `main`

Open

#617 opened on Oct 9, 2016

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (1,540 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

If a dependency (for instance, a package in node_modules) omits an extension in the main field of its package.json, the import/no-unresolved rule will fail.

For example:

// node_modules/foo/package.json
{
  name: "foo",
  version: "1.0.0",
  main: "index"
}

// node_modules/foo/index.js
const message = 'It is legal to omit a .js on "main" in package.json';
export default message;

// index.js
import foo from 'foo'; // This triggers the import/no-unresolved rule
console.log(foo);

I imagine this should be a simple fix.

Contributor guide

Research direction
Inspect the resolver logic for import/no unresolved to handle packages where the main field in package.json has no file extension. Add logic to try appending common extensions like .js, .mjs, .cjs.
Tech stack
javascriptnodejs
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80