import-js/eslint-plugin-import

Support for checking `require.resolve()`

Open

#585 opened on Sep 25, 2016

View on GitHub
 (2 comments) (4 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
acceptedenhancementhelp wanted

Description

Sometimes I use require.resolve() just to resolve paths to other resources than javascript modules.

Okay, this is not a regular import, but it would be nice if this plugin could also check these paths.

Maybe it could be a new setting like 'import/check-require-resolve': true, whereas various rules related to CommonJS imports also apply here.

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptNode.js require.resolve()ESLint plugin developmenteslint plugin import structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine how the plugin currently handles `require()` calls, particularly in rules like `no unresolved` and `no extraneous dependencies`. Identify where `require.resolve` is used as an expression and consider extending the AST visitor to detect `CallExpression` with callee `require.resolve`. Introduce a configuration option, e.g., `'import/check require resolve': true`, and apply the same import validation logic to the arguments of `require.resolve()`.
Support for checking `require.resolve()` · import-js/eslint-plugin-import#585 | Good First Issue