import-js/eslint-plugin-import

`import/order` not working well with direct parent index

Open

#483 opened on Aug 11, 2016

View on GitHub
 (2 comments) (3 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wantedimport/export ordering

Description

Hello there,

I'm trying to set up a config for the import/order but I have issues when using .. path to match with direct parent index (e.g. ../index.js).

This is the config I use:

'import/order': [ // Enforce a convention in module import order.
  'warn',
  {
    'groups': [
      'builtin',
      ['external', 'internal'],
      ['parent', 'sibling', 'index'],
    ],
    'newlines-between': 'always',
  },
],

And here is an example of where I get a wrong warning:

import moduleA from '../moduleA'; // import/order warning
import moduleB from '..';

It reports a warning on the first line: import/order: There should be at least one empty line between import groups. Thus, it is no more a problem when adding an ending / after module B's path:

import moduleA from '../moduleA';
import moduleB from '../';
// everything is fine

According to me it's a bug, as I don't have to declare import moduleA from '../moduleA/ to match an index.js file. What's your thoughts on this?

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptESLint plugin development
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Examine the `import/order` rule implementation in the repository, likely in `src/rules/order.js`. Look at how the rule groups imports and handles paths containing '..'. Identify why the rule treats `../moduleA` and `..` as different groups. Consider if the issue is about path resolution or group detection. Check for any existing tests related to parent directory imports.
`import/order` not working well with direct parent index · import-js/eslint-plugin-import#483 | Good First Issue