import-js/eslint-plugin-import

"Multiple exports of name 'xxx' import/export" error is thrown if types are exported

Open

#3136 opened on Jan 4, 2025

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wantedtypescript

Description

We have the following two files in the package:

m.ts

export interface Foo {}

export function f(foo: Foo): void {
}

index.ts

export {f} from 'm';
export type * from 'm';

Actual result:

While linting this code the plugin prints the following error for index.ts:

Multiple exports of name 'f' import/export

Expected result:

I don't expect the error to be thrown for the above case as the second expression in index.ts exports types, so there should be no duplicates.

Plugin version: 2.31.0

Contributor guide

Tech stack
javascripttypescript
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with TypeScriptUnderstanding of ESLint plugin structure
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the rule 'import/export' in the eslint plugin import source code. Check the implementation of how exports are compared, specifically the handling of `export type *`. The issue indicates that type only exports are not being filtered out when checking for duplicate exports. Likely the fix involves checking whether an export is a type export and excluding it from the duplicate check. Refer to the file that implements the rule, possibly `src/rules/export.js` or similar. Also consider linked issues or PRs that might address similar problems.