import-js/eslint-plugin-import

no-deprecated rule does not work if there are decorators

Open

#3094 opened on Nov 5, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

Normally, you put the docblock at the top of the function or class. To make it detect the @deprecated tag, the docblock needs to be after the decorators. I attached an image below

Image

Contributor guide

Tech stack
javascript
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
ESLint plugin developmentAST knowledgeunderstanding of decorators
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the no deprecated rule implementation, likely in src/rules/no deprecated.js. The rule needs to handle cases where decorators precede the function/class, and the JSDoc comment is attached to the decorated node. Check how the rule currently extracts @deprecated tags and consider adjusting the logic to also look at ancestor nodes or handle decorator chains. Look at existing tests for the rule to understand expected behavior and add a test case with decorators.