import-js/eslint-plugin-import

Disallow duplicate require

Open

#2925 opened on Nov 18, 2023

View on GitHub
 (9 comments) (1 reaction) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
enhancementhelp wanted

Description

I have following code :

const { addCellToRow } = require("./cell-utils.js");
const { setCellValue, findCell, createCell } = require("./cell-utils.js");

Both require are using the same path, and should thus be grouped.

I've tried to enable this in my .eslintrc :

"import/no-duplicates": ["error", {"prefer-inline": true}],

But it didn't have any effect.

Are there any rules that can catch this ?

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of ESLint plugin developmentFamiliarity with AST for require statements
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the existing `import/no duplicates` rule to understand why it does not catch duplicate `require()` calls. Check the rule's source code in the repository to see how it handles `import` vs `require`. Look at the issue comments for any suggested fixes or workarounds. Consider whether a new rule or an enhancement to the existing rule is needed.