import-js/eslint-plugin-import

[import/extensions] ".." and "." import paths are incorrectly flagged as requiring an extension, when either is al local package

Open

#2844 opened on Jul 31, 2023

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

In #2778, we determined that this plugin incorrectly flags ".." and "." import paths, when those imports refer to a local package (with a package.json).

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Understanding of ESLint custom rulesNode.js module resolution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue references #2778 where a similar case was discussed. To fix, examine the `import/extensions` rule implementation in the plugin, likely in `src/rules/extensions.js` or similar. Investigate how the rule determines whether a path is a local package by checking for a `package.json` in the directory. The fix should ensure that relative paths like '.' and '..' that resolve to a package (with a `package.json`) are not flagged as requiring an extension. Test cases should be added for this scenario.