import-js/eslint-plugin-import

[import/default]: false negative when importing CJS module which uses dynamic import

Open

#2769 opened on Apr 27, 2023

View on GitHub
 (5 comments) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
help wanted

Description

I found a weird problem with the import/default rule. See this minimal gist

I import two modules which are very similar, both being CJS with default export.

import ecmaScriptLiteralLoader from 'rdf-loader-code/ecmaScriptLiteral.js'
import ecmaScriptModuleLoader from 'rdf-loader-code/ecmaScriptModule.js'

The first is fine but the second triggers a rule

3:8  error  No default export found in imported module "rdf-loader-code/ecmaScriptModule.js"  import/default

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of CJS modulesFamiliarity with ESLint plugin developmentKnowledge of dynamic imports
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the `import/default` rule in the eslint plugin import repository. The bug occurs when a CJS module with a default export also uses dynamic imports, causing a false negative. Review the rule's logic for handling CJS modules, particularly how it determines default exports. The reproduction gist at https://gist.github.com/tpluscode/50d638600e4397a0bef4b3289cfb2925 provides minimal test cases. Look for any existing comments on the issue discussing potential causes or related code.