import-js/eslint-plugin-import

[import/no-duplicates] Extra comma added when fixer is run

Open

#2,757 opened on Apr 9, 2023

View on GitHub
 (0 comments) (2 reactions) (0 assignees)JavaScript (1,540 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

Input:

import { Foo } from "someImport";
import {
  BarLongNameToEnsureLineBreak,
  BazManLongNameToEnsureLineBreak,
} from "someImport";
import { Qux } from "someImport";

const foo: Foo = "foo";
const bar: BarLongNameToEnsureLineBreak = "bar";
const baz: BazManLongNameToEnsureLineBreak = "baz";
const qux: Qux = "qux";

output:

import { Foo ,
  BarLongNameToEnsureLineBreak,
  BazManLongNameToEnsureLineBreak,
, Qux } from "someImport";

const foo: Foo = "foo";
const bar: BarLongNameToEnsureLineBreak = "bar";
const baz: BazManLongNameToEnsureLineBreak = "baz";
const qux: Qux = "qux";

Note the commas at the end of line 3 and start of line 4.

Possibly related to #2601, tho in that case it appears that the opposite problem is occurring: no comma when there should be

Contributor guide

Research direction
Inspect the fixer logic in the no duplicates rule. Look at how the rule merges import statements and handles commas, especially when there are line breaks. Trace the code path that generates the output with extra commas.
Tech stack
javascript
Domain
backendtooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50