import-js/eslint-plugin-import

[import/no-duplicates] `{"prefer-inline": true}` does not work

Open

#2715 opened on Feb 12, 2023

View on GitHub
 (14 comments) (13 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wantedtypescript

Description

version 2.27.5

https://github.com/import-js/eslint-plugin-import/blob/main/docs/rules/no-duplicates.md#inline-type-imports The documentation states that adding {"prefer-inline": true} as shown below will cause errors and autofixes if there are duplicate imports. However, this was not possible in my environment.

{
  "import/no-duplicates": ["error", {"prefer-inline": true}],
}

It should look like the following, but there is no error or anything.

import NextErrorComponent from 'next/error';
import { type ErrorProps } from 'next/error';
// ↓
import NextErrorComponent, { type ErrorProps } from 'next/error';

image

Is this currently being corrected?

Contributor guide

Tech stack
javascripttypescriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic ESLint configurationTypeScript import syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Review the `no duplicates` rule implementation in the eslint plugin import repository, specifically how the `prefer inline` option is handled. Look at the rule's source file (likely `src/rules/no duplicates.js`) and its tests. Check if there are any existing PRs or issues addressing this. The documentation mentions inline type imports, but the actual behavior may not merge duplicate imports as expected. Focus on the logic that merges imports and how the option affects it.