import-js/eslint-plugin-import

False "Multiple exports of name" error when two "export * as ..." contain same name [import/export]

Open

#2289 opened on Nov 4, 2021

View on GitHub
 (3 comments) (2 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

The issue I am having seems related to https://github.com/import-js/eslint-plugin-import/issues/1834 That specific issue is fixed. But I am having the same issue when using an extra level of indirection. TypeScript does not seem to have a problem with the added level. So I guess this plugin should allow it...?

Scenario described in https://github.com/import-js/eslint-plugin-import/issues/1834

./A/A1.ts

export type X = "A1";

./A/A2.ts

export type X = "A2";

./A/index.ts

export * as A1 from "./A1";
export * as A2 from "./A2";

In this scenario, as described in https://github.com/import-js/eslint-plugin-import/issues/1834 there would be an error Multiple exports of name 'X'. There is no error. This is fixed.

My scenario

I have the same files as above. With the following added: ./B/B.ts

export type X = "B";

./B/index.ts

export * as B from "./B";

./index.ts

export * from "./A";
export * from "./B";

Now I get the same error (Multiple exports of name 'X') again for both lines in ./index.ts.

Having added this extra level of indirection with the index.ts files seems to mess up something.

As the original problem, this error can also be avoided by doing:

./index.ts

import { A1, A2 } from "./A";
import { B } from "./B";
export { A1, A2, B };

versions

"eslint": "^7.32.0",
"eslint-import-resolver-typescript": "^2.5.0",
"eslint-import-resolver-webpack": "^0.13.2",
"eslint-plugin-import": "^2.25.2",
"typescript": "^4.4.4",

Contributor guide

Tech stack
typescriptjavascriptnodejs
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with ESLint plugin structureunderstanding of TypeScript module resolution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Investigate how the plugin resolves 'export *' and 'export * as' in nested index files. Compare with the fix for issue #1834 which addressed the same error for direct re exports. The likely culprit is in the export rule's export map building logic, possibly in the 'resolve/re export' module. Check the file 'src/rules/export.js' or similar. Verify if the plugin correctly handles namespace re exports through intermediate index files.