import-js/eslint-plugin-import

no-unused-modules "missingExports" returns false positives

Open

#2102 opened on May 27, 2021

View on GitHub
 (7 comments) (1 reaction) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
`exports` supportbughelp wanted

Description

I'd expect both of these cases to count as exports:

module.exports = {} // Should probably not trigger

export * from './someFile' // Should almost definitely not trigger

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
eslintnpm module exports
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
The bug is in the no unused modules rule's missingExports logic. Examine the rule's source at src/rules/no unused modules.js and its tests in tests/src/rules/no unused modules.js. The issue involves detecting exports from `module.exports = {}` and `export * from './someFile'`. Look at how the rule currently gathers exports and why these cases are missed. Check GitHub for any existing PRs or comments that discuss the detection scope. The fix likely requires modifying the export extraction to include these patterns, ensuring they are considered as exports.