import-js/eslint-plugin-import

v2.23 no longer works with `Promise`-based Webpack configuration

Open

#2,069 opened on May 14, 2021

View on GitHub
 (15 comments) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
enhancementhelp wantedpackage: resolver/webpack

Description

Prior to v2.23, my webpack.config which returns a Promise<WebpackConfig[]> worked fine, but now it causes the following errors (LOTS of them):

Webpack config returns a `Promise`; that signature is not supported at the moment. Using empty object instead.

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingbuild system
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Webpack configurationPromise handling
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is that eslint plugin import v2.23 no longer supports Promise returning Webpack configurations. The change likely occurred in the commit that introduced array of configs support. Investigate the plugin's handling of Webpack config in the `resolve` or `parse` functions, particularly in the file `lib/core/importType.js` or similar. Look at the PRs/issues linked from v2.23 release notes. A fix would involve allowing the config to be a Promise and awaiting it before accessing properties.