import-js/eslint-plugin-import

[no-duplicates] incorrect report on two non-combinable ts type import statements

Open

#2,007 opened on Mar 14, 2021

View on GitHub
 (2 comments) (2 reactions) (0 assignees)JavaScript (1,540 forks)batch import
bughelp wantedtypescript

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

import type ESLint from 'eslint'
import type { Linter, SourceCode } from 'eslint'

If I merge them into one statement:

import type ESLint, { Linter, SourceCode } from 'eslint'

TS will fail to compile

packages/eslint-plugin-mdx/src/processors/options.ts:5:8 - error TS1363: A type-only import can specify a default import or named bindings, but not both.

5 import type ESLint, { Linter, SourceCode } from 'eslint'

Contributor guide

Research direction
Investigate the no duplicates rule's logic to detect when two type only import statements cannot be merged due to TypeScript's restriction that a type only import cannot have both a default and named bindings.
Tech stack
typescriptjavascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
TypeScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70