import-js/eslint-plugin-import

import/named does not report non-existent exports in yarn workspace

Open

#2005 opened on Mar 12, 2021

View on GitHub
 (6 comments) (1 reaction) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

Screen Shot 2021-03-12 at 9 45 07 AM

https://github.com/jd2rogers2/eslint-plugin-import-bug-minimal-repo for testing it for yourself

as seen above, no report for import/named despite not having an helloFooV2 export from foo/index.js foo and bar are both separate workspaces, bar lists foo as a dependency, and foo is in node_modules
i would expect it to report maybe a larger issue as there is also https://github.com/benmosher/eslint-plugin-import/issues/1832

Contributor guide

Tech stack
javascriptnodejs
Domain
developer experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of ESLint pluginsKnowledge of yarn workspacesFamiliarity with Node.js module resolution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the minimal reproduction repository at https://github.com/jd2rogers2/eslint plugin import bug minimal repo to understand the workspace structure. Examine the `import/named` rule implementation in the plugin's source code, focusing on how it resolves named exports from dependencies in a workspace context. Check if the issue is related to the module resolver not properly handling symlinked workspaces. Also review related issue #1832 for additional context. Consider writing a test case that replicates the scenario and verify if the bug is still present with the latest version of the plugin.