import-js/eslint-plugin-import

no-named-as-default-member rule is broken in specific cases

Open

#1,952 opened on Nov 19, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

import/no-named-as-default-member is broken in such a case:

// id-values-map.js

const ID_VALUE_MAP = {
  x: 4,
  y: 14,
};

const DEFAULT_ID = 'x';

export default ID_VALUE_MAP;
export { DEFAULT_ID };

// usage.js

import ID_VALUE_MAP, { DEFAULT_ID } from './id-values-map';

use(ID_VALUE_MAP[DEFAULT_ID]);
// ESLint: Caution: `ID_VALUE_MAP` also has a named export `DEFAULT_ID`. Check if you meant to write `import {DEFAULT_ID} from './id-values-map'` instead.(import/no-named-as-default-member)

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptESLint plugin basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
The bug occurs in the `no named as default member` rule. The rule incorrectly warns when a default export is an object that has a property with the same name as a named export. To fix, examine the rule's logic in `src/rules/no named as default member.js` and adjust the condition that triggers the warning. Consider adding a test case similar to the one provided in the issue.