import-js/eslint-plugin-import

no-extraneous-dependencies does not report when importing from subfolder

Open

#1,918 opened on Oct 5, 2020

View on GitHubContributor guide
 (3 comments) (2 reactions) (0 assignees)JavaScript (1,548 forks)batch import
bughelp wanted

Repository metrics

Stars
 (5,940 stars)
PR merge metrics
 (PR metrics pending)

Description

My eslint settings:

'import/no-extraneous-dependencies': ['error', { devDependencies: ['**/*.test.js'] }],

and package.json:

    "devDependencies": {
        ...
        "uuid": "^8.3.0",
    }

The following import does not error:

const v5 = require('uuid/v5')

However it does error, when using exact package name:

const { v5 } = require('uuid')

Its quite common practice, so I believe it should complain also when referencing individual files from a package...

Contributor guide

Research direction
Inspect the rule implementation for no extraneous dependencies to see how it resolves package names and check if subpath imports (e.g., 'uuid/v5') are handled. Look at the resolve function and see if it considers subfolders as part of the package.
Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75