import-js/eslint-plugin-import

no-extraneous-dependencies does not report when importing from subfolder

Open

#1918 opened on Oct 5, 2020

View on GitHub
 (3 comments) (2 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

My eslint settings:

'import/no-extraneous-dependencies': ['error', { devDependencies: ['**/*.test.js'] }],

and package.json:

    "devDependencies": {
        ...
        "uuid": "^8.3.0",
    }

The following import does not error:

const v5 = require('uuid/v5')

However it does error, when using exact package name:

const { v5 } = require('uuid')

Its quite common practice, so I believe it should complain also when referencing individual files from a package...

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint plugin developmentNode.js module resolution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue is about the 'no extraneous dependencies' rule not flagging imports from subdirectories of devDependencies (e.g., require('uuid/v5')). The relevant source file is likely 'src/rules/no extraneous dependencies.js'. The current logic checks if the imported module name matches a package exactly, but does not handle subpath imports. The contributor should examine how the rule extracts the package name from the import specifier and extend it to also handle cases where the specifier starts with a package name followed by a slash. The comments in the issue may contain additional details. No pull requests are linked.