import-js/eslint-plugin-import

`no-extraneous-dependencies` doesn't support nested package.json

Open

#1,913 opened on Sep 29, 2020

View on GitHub
 (7 comments) (12 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
enhancementhelp wanted

Description

With Node’s ES Module support explicitly suggesting to use multiple package.json files in subfolders, I think no-extraneous-dependencies should automatically support nested package.json without further config

The nearest parent package.json is defined as the first package.json found when searching in the current folder, that folder’s parent, and so on up until the root of the volume is reached.

I know that no-extraneous-dependencies has options to manually specify each folder, but I think that this could be done automatically.

Contributor guide

Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of ESLint plugin architectureFamiliarity with Node.js module resolution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
55
Research direction
Examine the current implementation of `no extraneous dependencies` rule in the eslint plugin import repository (likely in `src/rules/no extraneous dependencies.js`). Understand how it currently resolves package.json files and how it uses options for custom folder paths. Implement automatic detection by searching for the nearest parent package.json from each file's directory, as per Node.js resolution algorithm, without requiring explicit configuration. Check if there are any existing PRs or discussions related to this feature.