import-js/eslint-plugin-import

Suggestion [`no-named-default`]: add option to allow type imports with multiple imports

Open

#1,869 opened on Aug 5, 2020

View on GitHub
 (6 comments) (4 reactions) (0 assignees)JavaScript (1,540 forks)batch import
bughelp wantedtypescript

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

Typescript's import type cannot be used to import the default export and named exports without using default as:

import type Foo, {Bar} from 'foo'
// A type-only import can specify a default import or named bindings, but not both.

However, these both work but trigger no-duplicates and no-named-default respectively:

import type Foo from 'foo'
import type {Bar} from 'foo'

import type {default as Foo, Bar} from 'foo'

Could there be a new option to no-named-default that allows type imports with multiple imports? For example:

import type {default as Foo} from 'foo' // lint warning
import type {default as Foo, Bar} from 'foo' // fine

Contributor guide

Research direction
Look at the `no named default` rule implementation in `eslint plugin import` and understand how options are handled. Then add a new option (e.g., `allowTypeImports`) to allow `default as` usage when the import is a type only import with multiple bindings.
Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65