import-js/eslint-plugin-import

`dynamic-import-chunkname` does not allow additional comments

Open

#1,840 opened on Jun 29, 2020

View on GitHub
 (1 comment) (1 reaction) (0 assignees)JavaScript (1,540 forks)batch import
help wanted

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

eslint: v7.3.1 eslint-plugin-import: v2.22.0

Eslint rule:

"rules": {
	"import/dynamic-import-chunkname": "error",
}

Code:

import(
	/* webpackInclude: /\.json$/ */
	/* webpackChunkName: "module" */
	"./module.js"
);

Produces error:

  1:1  error  dynamic imports require a leading comment in the form /* webpackChunkName: "[0-9a-zA-Z-_/.]+",? */  import/dynamic-import-chunkname

Version 2.21.2 works well

Contributor guide

Research direction
Inspect the rule source code for `dynamic import chunkname`, locate the regex or logic that validates the leading comment, and modify it to allow additional comments (like `/* webpackInclude */`) before or after the required `/* webpackChunkName */` comment.
Tech stack
javascript
Domain
devtools
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75