import-js/eslint-plugin-import

`no-duplicates` rule has incorrect autofix when comment is present

Open

#1,838 opened on Jun 26, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (1,540 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

Original:

import { set } from '@ember/object';
import EmberObject, { observer, computed } from '@ember/object'; // some comment

Autofixes to (invalid):

import EmberObject, { set } from '@ember/object';
import EmberObject, { observer, computed } from '@ember/object'; // some comment

Without the comment, this correctly autofixes to:

import EmberObject, { set, observer, computed } from '@ember/object';

Contributor guide

Research direction
Investigate the autofix logic for the no duplicates rule, focusing on how comments are preserved during the fix.
Tech stack
javascript
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintJavaScript
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70