import-js/eslint-plugin-import

Support for named aggregate export pattern in import/name

Open

#1,753 opened on May 10, 2020

View on GitHub
 (13 comments) (13 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

Apologies if this is ultimately the same bug as described in #1583 but it is a slightly different circumstance so I wanted to post it separately in case it is distinct

Given:

// constants.js
export const x = 5
export const y = 6

// index.js
export * as constants from './constants'

The following is considered invalid:

// sandbox.js
import { constants } from './index'

Error:

ESLint: constants not found in './index' (import/named)

However, the following is considered valid

// sandbox.js
import * as blah from './index'

and indeed blah.constants is populated correctly.

My configuration:

{
  "extends": "airbnb-base",
  "parser": "babel-eslint",
  "rules": {
    "semi": [2, "never"],
    "indent": [2, "tab"],
    "no-tabs": 0
  },
  "env": {
    "es6": true,
    "node": true,
    "jest": true
  }
}

Eslint version: v6.8.0

Contributor guide

Tech stack
javascriptnodejs
Domain
developer experiencetooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint plugin development fundamentalsJavaScript ES module syntax
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
Investigate the handling of `export * as` syntax in eslint plugin import. The bug is in the import/named rule which doesn't recognize named exports from aggregated re exports. Check the export resolution logic in src/rules/named.js and src/export resolution.js. Examine the related issue #1583 for context and potential solutions. Look at how the plugin constructs the export map for files using `export * as`.