import-js/eslint-plugin-import

Doesn't differentiate between `module-name` and `@namespace/module-name`

Open

#1,747 opened on May 4, 2020

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

I'm working in a monorepo with a package named @arc/dotenv which requires dotenv. This triggers import/no-self-import. My suspicion is that it's not taking the namespace into account. Another possibility: the package lives at <root>/tools/dotenv, so perhaps the issue comes up after the module gets resolved?

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint plugin developmentmodule resolution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the `no self import` rule in `src/rules/no self import.js` to understand how it matches module names. Check if it uses `resolve` to resolve the module path and if it correctly handles scoped package names (e.g., `@arc/dotenv`). Look at the resolver logic for monorepo setups and verify whether the scope is stripped during comparison.
Doesn't differentiate between `module-name` and `@namespace/module-name` · import-js/eslint-plugin-import#1747 | Good First Issue