import-js/eslint-plugin-import

`import/no-unresolved` has false positives for search query

Open

#1,739 opened on Apr 29, 2020

View on GitHub
 (11 comments) (15 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wantedpackage: resolver/node

Description

image

Queries are supported: https://nodejs.org/api/esm.html#esm_url_based_paths

Using eslint@6.8.0 and eslint-plugin-import@2.20.2

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.js ESM basicsESLint plugin conceptsimport/no unresolved rule
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
45
Research direction
The issue is that the `no unresolved` rule incorrectly flags imports with query strings as unresolved. The Node.js ESM spec supports query strings, so the resolver needs to strip them before checking file existence. The fix likely involves modifying the resolve function in the import plugin to ignore query strings. The discussion in the issue suggests that a simple `path.split('?')[0]` might suffice, but needs to be integrated into the resolution pipeline.
`import/no-unresolved` has false positives for search query · import-js/eslint-plugin-import#1739 | Good First Issue