import-js/eslint-plugin-import

[BUG] ESLint crashes with `import/no-unused-modules`: Cannot read property 'get' of undefined

Open

#1,716 opened on Apr 2, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (1,540 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

Eslint-plugin-import crashes running eslint with Cannot read property 'get' of undefined error.

The error is in lib/rules/no-unused-module.js on line 262:

exportAll.forEach((value, key) => { value.forEach(val => { **const currentExports = exportList.get(val);** const currentExport = currentExports.get(EXPORT_ALL_DECLARATION); currentExport.whereUsed.add(key); }); }); However, if I add condition:

if (currentExports) { const currentExport = currentExports.get(EXPORT_ALL_DECLARATION); currentExport.whereUsed.add(key); } the lint works and I can see all the lint errors .

For now, I disabled the rule in .eslintrc.js file, but would it be possible to create a fix for it, or can I do it as well?

Version: "eslint-plugin-import": "^2.20.0"

Contributor guide

Research direction
Inspect lib/rules/no unused module.js line 262, trace the exportList map to understand when get returns undefined, add a conditional check before accessing currentExports.
Tech stack
javascriptnodejs
Domain
devtoolstesting
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70