import-js/eslint-plugin-import

v2.20.2 import/order triggered only after adding newline

Open

#1,711 opened on Mar 31, 2020

View on GitHub
 (4 comments) (2 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wantedimport/export ordering

Description

OS: Ubuntu 18 Node: 12.16.1 Eslint: 6.8.0 (bundled with CRA) Eslint-plugin-import: 2.20.2 (bundled with CRA) Eslint-config-create-react-app: 5.2.1 (bundled with CRA, source)

Steps to reproduce

  1. Install create-react-app
  2. Add import/order rule with groups via EXTEND_ESLINT
  3. Run it - no errors occured
  4. Add newline before function App() { (2 newline between import and function now)
  5. Save - now error occured
./src/App.js
  Line 4:1:  `./logo.svg` import should occur before import of `react`  import/order

Search for the keywords to learn more about each error.

Or

  1. Checkout https://github.com/koutsenko/sort-imports
  2. Run it - it will print error
  3. Remove one of two newlines between import and function statements
  4. Import error will gone.

Question: why import rules are triggered by adding newline?

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Basic JavaScriptUnderstanding of ESLint rules
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Investigate the import/order rule source code, particularly the logic that determines import ordering. Focus on how the rule handles whitespace and newlines between imports and other statements. Look at the AST parsing to see if the rule incorrectly interprets the context. Check the repository's test cases for import/order to understand expected behavior. The minimal reproduction repository is at https://github.com/koutsenko/sort imports.