import-js/eslint-plugin-import

`no-commonjs` does not appear to work for TypeScript

Open

#1,709 opened on Mar 30, 2020

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
help wantedtypescript

Description

I have the following rule enabled:

    // disallow require()
    // https://github.com/benmosher/eslint-plugin-import/blob/master/docs/rules/no-commonjs.md
    'import/no-commonjs': 'error',

However, in my TypeScript source file, the following line that I expected to error does not:

import Boom = require('boom')

Should it?

Contributor guide

Tech stack
typescriptjavascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
TypeScriptESLint plugin development basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the no commonjs rule implementation in src/rules/no commonjs.js. Determine if the rule currently handles TypeScript specific import syntax like `import = require()`. Check the issue comments for any maintainer guidance on expected behavior. Consider how other rules in the plugin handle TypeScript AST nodes.