import-js/eslint-plugin-import

import/no-relative-parent-imports report incorrectly in 2.20.1

Open

#1,644 opened on Feb 3, 2020

View on GitHub
 (15 comments) (5 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wantedtypescript

Description

In version 2.20.1, I start to get errors like:

Relative imports from parent directories are not allowed. Please either pass what ...

for

import React from 'react';

The problem did not occur in 2.20.0.

I use eslint-typescript but since this used to work in 2.20.0 I doubt that this has anything to do with that.

My .eslintrc.js looks like this

parser: '@typescript-eslint/parser',
parserOptions: {
  project: path.resolve(__dirname, './tsconfig.json')
},
plugins: [
  'react',
  'react-hooks'
],
extends: [
  'plugin:@typescript-eslint/recommended',
  'plugin:react/recommended',
  'plugin:import/errors',
  'plugin:import/warnings',
  'plugin:import/typescripts',
]

Contributor guide

Tech stack
javascripttypescriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
Understanding of ESLint pluginsFamiliarity with eslint plugin importAbility to compare git diffs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Investigate the changes between v2.20.0 and v2.20.1 in the eslint plugin import repository, focusing on the `no relative parent imports` rule. Look at the rule's source code and any related configuration parsing. The issue suggests that the rule incorrectly flags imports like `import React from 'react'` when using TypeScript with parserOptions.project. Check if the regression is connected to the parser or the rule's logic for determining parent imports. Consider testing with a minimal reproduction using the provided config.