import-js/eslint-plugin-import

Support for named import pattern in import/named

Open

#1,583 opened on Dec 26, 2019

View on GitHub
 (4 comments) (3 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

Given:

// ./foo.js
export const foo = "I'm so foo"

The following Es6 syntax is considered invalid:

// ./bar.js
import { foo as bar } from './foo'

Error:

ESLint: foo not found in './foo'(import/named)

However, the following is considered valid

// ./bar.js
import * as bar from './foo'

is it done intentionally? And if so, do we have an option to disable errors?

My configuration:

{
    "env": {
        "browser": true,
        "jest": true
    },
    "parserOptions": {
        "sourceType": "module",
        "ecmaFeatures": {
            "jsx": true
        }
    },
    "extends": [
        "airbnb",
        "plugin:prettier/recommended"
    ],
    "plugins": [
        "react"
    ],
    "rules": {
        "class-methods-use-this": 0,
        "import/no-named-as-default": 0,
        "react/jsx-filename-extension": [
            "error",
            {
                "extensions": [
                    ".js",
                    ".jsx"
                ]
            }
        ]
    }
}

Eslint version: v6.8.0

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScript ES6 modulesESLint plugin developmentNode.jsAST basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Investigate the `import/named` rule implementation in eslint plugin import. The bug occurs when using alias syntax (`import { foo as bar }`). Examine the rule's source code (likely `src/rules/named.js`) to understand how it resolves exported names. Check existing tests for named imports to see if aliases are covered. The fix likely involves updating the logic to match the original exported name (`foo`) instead of the alias (`bar`). Consider how the rule currently handles namespace imports (`import * as bar`) and apply similar logic to named imports with aliases.