import-js/eslint-plugin-import

no-unused-modules doesn't report unused Flow type exports

Open

#1,540 opened on Nov 13, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bugflowhelp wanted

Description

// foo.js

// @flow strict
export type Foo = string
export default ''

// index.js

// @flow strict
import foo from './foo'

Expected: export type Foo is reported as unused Actual: no errors

Contributor guide

Tech stack
javascript
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
knowledge of ESLintunderstanding of Flow typesfamiliarity with the no unused modules rule
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the `no unused modules` rule implementation in `src/rules/no unused modules.js`. Focus on how type exports are processed—Flow type exports may not be recognized as exports in the module graph. Check the parsing logic for `// @flow` annotations and ensure that Flow type exports are included in the list of exports. Look at existing tests for patterns and consider adding a test case for Flow type exports.