import-js/eslint-plugin-import

no-unused-modules does not work with `module.exports`

Open

#1,469 opened on Sep 4, 2019

View on GitHub
 (2 comments) (3 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
enhancementhelp wanted

Description

Eslint output: 1:1 warning No exports found import/no-unused-modules

Actual file content: module.exports = app;

Versions:

"eslint": "^6.3.0",
"eslint-plugin-import": "^2.18.2",

Config:

{
  "env": {
    "es6": true,
    "node": true
  },
  "extends": "eslint:recommended",
  "globals": {
    "Atomics": "readonly",
    "SharedArrayBuffer": "readonly"
  },
  "parserOptions": {
    "ecmaVersion": 2019,
    "sourceType": "module"
  },
  "plugins": ["import"],
  "rules": {
    "eqeqeq": "error",
    "no-unused-expressions": "error",
    "no-unused-vars": [
      "warn",
      {
        "vars": "all",
        "args": "none"
      }
    ],
    "import/no-unused-modules": [
      1,
      {
        "missingExports": true,
        "unusedExports": true
      }
    ]
  }
}

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Familiarity with ESLint rulesKnowledge of AST
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Examine the rule implementation in src/rules/no unused modules.js to see how exports are detected. Add logic to handle module.exports by traversing AssignmentExpression nodes. Check the test file at tests/src/rules/no unused modules.js and add corresponding test cases.