import-js/eslint-plugin-import

Use globbing with `no-unused-modules` options

Open

#1,326 opened on Apr 14, 2019

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
enhancementhelp wantedquestion

Description

I would like to check for dead code in my test helpers using the no-unused-modules rule.

My test folder is test/ and my helpers are in test/helpers/ (which is a common setup with Ava).

The src and ignoreExports are file paths, which makes it hard to use in such a setup. Indeed I need src to target my test files + helpers (test/) but ignoreExports should exclude the test files since they do not export anything.

One possible solution would be to allow globbing in src and ignoreExports, e.g. { src: 'test/', ignoreExports: ['test/', '!test/helpers'] }. What do you think?

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptESLint plugin developmentglob patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65
Research direction
Look at the rule implementation in `rules/no unused modules.js`. Understand how `src` and `ignoreExports` options are currently processed. Implement glob support by integrating a library like `minimatch` or `glob`, update option validation, and add tests for the new behavior. Check existing test patterns for inspiration.
Use globbing with `no-unused-modules` options · import-js/eslint-plugin-import#1326 | Good First Issue