import-js/eslint-plugin-import

Use globbing with `no-unused-modules` options

Open

#1,326 opened on Apr 14, 2019

View on GitHub
 (3 comments) (1 reaction) (0 assignees)JavaScript (1,540 forks)batch import
enhancementhelp wantedquestion

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

I would like to check for dead code in my test helpers using the no-unused-modules rule.

My test folder is test/ and my helpers are in test/helpers/ (which is a common setup with Ava).

The src and ignoreExports are file paths, which makes it hard to use in such a setup. Indeed I need src to target my test files + helpers (test/) but ignoreExports should exclude the test files since they do not export anything.

One possible solution would be to allow globbing in src and ignoreExports, e.g. { src: 'test/', ignoreExports: ['test/', '!test/helpers'] }. What do you think?

Contributor guide

Research direction
Implement glob support in src and ignoreExports options for no unused modules rule. Modify the option parsing to accept glob patterns and test with various use cases.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
ESLintnodejs
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60