import-js/eslint-plugin-import

Groups not being detected properly?

Open

#1,303 opened on Mar 19, 2019

View on GitHub
 (4 comments) (2 reactions) (0 assignees)JavaScript (1,540 forks)batch import
bughelp wanted

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 5d 21h) (9 merged PRs in 30d)

Description

Am I misunderstanding something, or is this a bug? The newline is exactly in the right place.

"rules": {
  "import/order": [
    "warn",
    {
      "groups": ["builtin", "external", "parent", "sibling", "index"],
      "newlines-between": "always"
    }
  ],

import React from 'react';
import { hot } from 'react-hot-loader';
import { BrowserRouter, Route, Switch } from 'react-router-dom';   // <--- warning  There should be no empty line within import group  import/order

import { Footer } from 'components/Footer';
import { Header } from 'components/Header';
import { Login } from 'components/Login';

Contributor guide

Research direction
Investigate the import/order rule source code in the eslint plugin import repository to understand how it detects groups and newlines. Reproduce the issue using the provided configuration and example imports. Check existing tests for similar cases and review comments on this issue for any additional context.
Tech stack
javascript
Domain
developer experiencetooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Mostly clear
Prerequisites
ESLintJavaScriptimport/order rule
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40