import-js/eslint-plugin-import

Alias definition in Babel module resolver causes no-relative-parent-imports since v2.15.0

Open

#1,299 opened on Mar 11, 2019

View on GitHub
 (10 comments) (2 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
help wanted

Description

Since eslint-plugin-import 2.15.0 the following Eslint configuration

settings: {
    'import/resolver': {
      'babel-module': {
        cwd: __dirname,
        alias: {
          $shared: '../shared',
          '~': '.'
        }
      }
    }
  }

causes

  ×   8:38  Relative imports from parent directories are not allowed. Please either pass what you're importing through at runtime (dependency injection), move cli.js to same directory as $shared/kiosk-ui-message-file-reader or consider making $shared/kiosk-ui-message-file-reader a package.    import/no-relative-parent-imports

Is this new behavior intended?

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
needs maintainer response
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ESLint configurationeslint plugin import rule no relative parent importsbabel module resolver alias setup
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Check the rule implementation in `src/rules/no relative parent imports.js` and the resolver in `utils/resolve.js`. Look at the commit history for changes around v2.15.0. Review the tests in `tests/src/rules/no relative parent imports.js` to see if this case is covered. Determine if the behavior is intended by consulting the maintainers or documentation.