import-js/eslint-plugin-import

Alias definition in Babel module resolver causes no-relative-parent-imports since v2.15.0

Open

#1,299 opened on Mar 11, 2019

View on GitHub
 (10 comments) (2 reactions) (0 assignees)JavaScript (1,540 forks)batch import
help wanted

Repository metrics

Stars
 (4,946 stars)
PR merge metrics
 (Avg merge 138d 22h) (3 merged PRs in 30d)

Description

Since eslint-plugin-import 2.15.0 the following Eslint configuration

settings: {
    'import/resolver': {
      'babel-module': {
        cwd: __dirname,
        alias: {
          $shared: '../shared',
          '~': '.'
        }
      }
    }
  }

causes

  ×   8:38  Relative imports from parent directories are not allowed. Please either pass what you're importing through at runtime (dependency injection), move cli.js to same directory as $shared/kiosk-ui-message-file-reader or consider making $shared/kiosk-ui-message-file-reader a package.    import/no-relative-parent-imports

Is this new behavior intended?

Contributor guide

Research direction
Examine the code for the no relative parent imports rule and the babel module resolver to understand how aliases are resolved. Check the changelog and git history for version 2.15.0 to identify the commit that changed behavior. Then adjust the rule to skip the check when the import is resolved via an alias that expands to a relative parent path.
Tech stack
javascript
Domain
developer experience
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaScriptESLint
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60