import-js/eslint-plugin-import

Linter mistakenly assumes global module is a parent directory of the project

Open

#1,291 opened on Feb 19, 2019

View on GitHub
 (3 comments) (5 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

I have code doing an import like:

import {all} from 'redux-saga/effects';
import {REHYDRATE} from 'redux-persist/constants';

Producing the linter errors below:

1:25  error  Relative imports from parent directories are not allowed. Please either pass what you're importing through at runtime (dependency injection), move `session.js` to same directory as `redux-persist/constants` or consider making `redux-persist/constants` a package  import/no-relative-parent-imports

11:8  error  Relative imports from parent directories are not allowed. Please either pass what you're importing through at runtime (dependency injection), move `index.js` to same directory as `redux-saga/effects` or consider making `redux-saga/effects` a package  import/no-relative-parent-imports

Clearly the suggested resolution in the error doesn't make sense but I'm not sure why it thinks this should be the case. #793 has some similarities but I'm not sure if those are superficial or real.

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Understanding of ESLintJavaScript module resolution basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue involves a false positive in the import/no relative parent imports rule. Investigate the rule's implementation in the eslint plugin import repository, particularly how it determines whether an import path is a parent directory. The rule likely uses a path resolving function that may incorrectly treat non relative paths (e.g., 'redux saga/effects') as relative when they start with a name that matches a parent directory pattern? Check the rule at 'src/rules/no relative parent imports.js' and see how it resolves the import source. Also, examine issue #793 for similar false positives. Consider whether the issue is in the module resolver or the rule itself.