import-js/eslint-plugin-import

regression: no-extraneous-dependencies when lint target file in a module sub-folder containing package.json

Open

#1,270 opened on Jan 25, 2019

View on GitHub
 (2 comments) (1 reaction) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
bughelp wanted

Description

Using node@10.15.0 on OSX. Upgraded eslint-plugin-import from 2.14.0 to 2.15.0. Have a package.json that includes numerous dependencies of the form:

"xyz": "git+ssh://git@github.home.247-inc.net:platform/xyz.git#0.0.8",

When running eslint@5.12.1 I now get errors of the following form:

error 'xyz' should be listed in the project's dependencies. Run 'npm i -S xyz' to add it import/no-extraneous-dependencies

Reverting to 2.14.0, the errors are no longer reported.

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsESLint plugin developmentnpm package resolution
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the regression from v2.14 to v2.15 in the no extraneous dependencies rule. The issue is that git+ssh dependencies are incorrectly flagged as missing. Look at the rule source in src/rules/no extraneous dependencies.js and the module resolution utilities. Check the changelog or diff between versions to identify the relevant commit. Test with a package.json containing git dependencies to understand the parsing logic.