import-js/eslint-plugin-import

import/named doesn't work when the target has no exports

Open

#1,147 opened on Jul 30, 2018

View on GitHub
 (2 comments) (0 reactions) (0 assignees)JavaScript (4,946 stars) (1,540 forks)batch import
help wanted

Description

Given:

// a.js
console.log('This file has no exports')

// b.js
import { doesntExist } from './a'

I'd expect the import/named rule to show an error for doesntExist. It doesn't. What am I missing? Is there a way to check for this type of error?

Contributor guide

Tech stack
javascriptnodejs
Domain
toolingdeveloper experience
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptESLint plugin developmentNode.js
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look at the rule implementation for `import/named` in the source tree, likely under `src/rules/named.js`. Examine the current logic that checks named exports and see where it fails when the module has no exports. Consider adding a test case for a module with no exports importing a non existent named export. Also check the resolver or module parsing to understand how exports are obtained.