import-js/eslint-plugin-import

no-cycle: consider deep require calls

Open

#1,056 opened on Mar 30, 2018

View on GitHub
 (6 comments) (7 reactions) (1 assignee)JavaScript (4,946 stars) (1,540 forks)batch import
help wantedsemver-minor

Description

Just making a note to come back to no-cycle and capture require calls in ExportMap to check for cycles in addition to exploring import statements.

Contributor guide

Tech stack
javascriptnodejs
Domain
tooling
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
needs investigation
Prerequisites
ESLint plugin structureJavaScript AST traversalUnderstanding of module resolutionCycle detection concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
Explore the ExportMap module in the eslint plugin import repository (likely utils/ExportMap.js). Review the existing no cycle rule implementation (e.g., rules/no cycle.js) to understand current import cycle detection. Check comments on issue #1056 for any additional context or proposed approaches. The goal is to modify ExportMap to also track require() calls, then update the no cycle rule to incorporate that data.