imaNNeo/fl_chart

`BarChartRodData.borderRadius` does not support `BorderRadiusDirectional`

Open

#1,189 opened on Nov 24, 2022

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Dart (1,964 forks)batch import
Fundamentalenhancementgood first issue

Repository metrics

Stars
 (7,513 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

Describe the bug BarChartRodData.borderRadius does not support BorderRadiusDirectional, as its type is constrained to the BorderRadius implementation instead of the abstract BorderRadiusGeometry representation.

The same happens with FlBorderData.border, which expects a Border instead of a BorderGeometry.

It may be a feature rather than a bug, but I vote for the ability to use these directionality utilities.

To Reproduce Provide a BorderRadiusDirectional object into the BarChartRodData.borderRadius property, or into FlBorderData.border.

Screenshots

Versions

  • which version of Flutter are you using? 3.3.9
  • which version of FlChart are you using? 0.55.2

Contributor guide

Research direction
Update the type of `borderRadius` in `BarChartRodData` from `BorderRadius` to `BorderRadiusGeometry`, and similarly for `FlBorderData.border` from `Border` to `BorderGeometry`. Ensure backward compatibility by adjusting internal usage and tests.
Tech stack
dart
Domain
frontend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
FlutterDart
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70