ihhub/fheroes2

Battle screen, dialog windows don't stop idle timer for troops

Open

#7,469 opened on Jul 24, 2023

View on GitHubContributor guide
 (2 comments) (0 reactions) (0 assignees)C++ (469 forks)auto 404
bughelp wantedui

Repository metrics

Stars
 (3,415 stars)
PR merge metrics
 (PR metrics pending)

Description

Preliminary checks

Platform

Windows

Describe the bug

https://github.com/ihhub/fheroes2/assets/55348946/5600d7e8-e536-4c57-82e7-4759368a0a6f

Once any dialog is opened, idle animation timer is still on. So, after waiting a couple of moments and closing the dialog, all creatures perform idle animation all together.

Save file

None.

Additional info

No response

Contributor guide

Research direction
Inspect the code for handling dialog windows (e.g., Dialog class) and the idle animation timer. Find where the timer is started/stopped and ensure it is paused when a modal dialog is shown.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++Game loop understanding
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70