ihhub/fheroes2

String contexts for several strings

Open

#5,248 opened on Apr 10, 2022

 (4 comments) (0 reactions) (0 assignees)C++ (469 forks)auto 404
good first issueimprovementtranslation

Repository metrics

Stars
 (3,415 stars)
PR merge metrics
 (PR metrics pending)

Description

Preliminary checks

Describe the problem requiring a solution

More contexts should be added for these strings both for improving the game and to accomodate for other languages:

  • Abbreviated and unabbreviated building names to be allowed to write things like Upgraded blacksmith where the space permits it. This would be very helpful for many languages that lack a proper translation for "upgraded": image

  • Arena primary skills. The German word Verteidigung is randomly broken mid-word image

  • Class in scenario information. This should be seen in relation to https://github.com/ihhub/fheroes2/issues/5244 image

  • Speed in the combat options. Speed in this case is different from the speed attribute of creatures for several languages. (Polish is used to show where I'm talking about. Not sure if this is the case for Polish.) imageimage

  • Spell names in cases they should be contained within 2 lines and not. A solution of implementing line-breaking at hyphens - wouldn't be optimal because the hyphen should be removed if single-lined. imageimage

  • Secondary skill level placed on the bottom of the skill icon is definable for each skill in translations of the OG. This is needed for cases when the adjective changes gender like "Logistica Esperta" but "Orientamento Esperto". This avoids unnecessary use of /. image

Describe the possible solution

For the most part you would need to add the usual context prefix ex. combatOption|Speed. For Classes you'll need to create another enumeration since right now only the Necromancer class has its own context in a switch - another approach should probably be used to avoid having to switch through every class name.

Additional info

No response

Contributor guide