ihhub/fheroes2

Castle screen, Captain's Quarters has part of castle wall in Warlock town

Open

#4,536 opened on Nov 2, 2021

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)C++ (469 forks)auto 404
help wantedimprovementoriginal assets

Repository metrics

Stars
 (3,415 stars)
PR merge metrics
 (PR metrics pending)

Description

Preliminary checks

Platform

Windows

Describe the bug

In a town without castle, Captain's Quarters has a part of castle wall, where the shadow of Captain's Quarters lays: image image Try to Switch between both these screens, and you will see, what elements should be deleted. This flaw presents in the OG too. I also suggest to take away the bridge to castle, the same we implemented to Necromancers Captain's Quarters. Quarters wall Note, that we would need a shadow of this building too.

Edit: The road to the right side of Captain's Quarters is smudged. image While before Captain's quarters it looks ok. image

Save file

Any Warlock town without castle.

Additional info

No response

Contributor guide

Research direction
Locate the image assets for the Warlock town Captain's Quarters (e.g., in the graphics directory). Identify the overlapping wall part and the shadow issue. Compare with the Necromancer's Captain's Quarters fix to understand the expected approach. Edit the sprite to remove the wall part and add the missing shadow. Test in game.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitBasic knowledge of game assets
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65