ihhub/fheroes2

Additional message window with greater width

Open

#1,338 opened on Aug 25, 2020

View on GitHubContributor guide
 (2 comments) (1 reaction) (0 assignees)C++ (469 forks)auto 404
help wantedimprovementui

Repository metrics

Stars
 (3,415 stars)
PR merge metrics
 (PR metrics pending)

Description

Fheroes2 has remedied some flaws present in the original game regarding the information displayed in some windows.

For example, with the window displayed when a map event that gives more than two types of resources is activated.

In the original game:

Additional message window with greater width 04

In fheroes2:

Additional message window with greater width 01

Or, when the hero goes to the hill fort and there are more than two troops to upgrade.

In the original game:

Additional message window with greater width 05

In fheroes2:

Additional message window with greater width 03

However, as you can see, this is sometimes a problem. The window displayed is not wide enough.

And if the text to display is very long, the top and bottom of the window are cut off.

Additional message window with greater width 02

To remedy this, it would be necessary to have in addition a larger version of the message display window (or a version that adapts automatically) that would be used when these cases occur.

Contributor guide

Research direction
Identify the code that creates message windows for map events and hill forts. Look for width constraints and modify them to accommodate longer text, possibly using dynamic sizing.
Tech stack
cpp
Domain
game devdesktop
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitC++
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60