ihhub/fheroes2

Spell sounds on high animation speeds

Open

#1,058 opened on Jul 17, 2020

View on GitHubContributor guide
 (10 comments) (0 reactions) (0 assignees)C++ (469 forks)auto 404
audiohelp wantedquestion

Repository metrics

Stars
 (3,415 stars)
PR merge metrics
 (PR metrics pending)

Description

Some sound effects of spells last more, than spell animation itself, when adjusting higher battle animation speed. Causing a mess of sounds and animation. "Holy Shout" spell, for example, has long lasting sound effect, and on high speeds animations, finishes at the time sound is still in process, We've already met same problem with teleport spell. #681 In the OG spell animation seemed not to effect by battle speed adjustment. How do we make up with this issue? Shall we take away dependency of battlespeed and spell animations? Or can we speed up spell animation, till the moment, sound finishes? Or can we speed up sounds of spells together, with spell animation? If we decide to speed up spell animation, we can use two last proposals together.

Contributor guide

Research direction
Investigate how spell animation duration and sound effect duration are currently set, and explore options to synchronize them when battle speed is changed. Consider decoupling sound from animation speed or speeding up sound together with animation.
Tech stack
cpp
Domain
game dev
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
C++fheroes2 codebase familiarity
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60