igorkasyanchuk/rails_performance

question: why append RailsPerformance::Extensions to LogSubscriber instead of integrating with Rails notifications directly

Open

#31 opened on May 3, 2021

View on GitHub
 (1 comment) (3 reactions) (0 assignees)Ruby (91 forks)github user discovery
help wanted

Repository metrics

Stars
 (1,237 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

I installed rails_performance on a rails 6.x application and ran a number of page requests. "Recent Requests" included everything as expected. However, the trace info for every request via TraceReport data section was blank.

My rails application uses rails_semantic_logger, which replaces the default ActionView::LogSubscriber and ActiveRecord::LogSubscriber. This prevented rails_performance from tracking the logsubscriber events.

I was able to resolve this by appending the RailsPerformance::Extensions::Db module to the appropriate RailsSemanticLogger LogSubscriber class.

Since ActiveSupport::LogSubscriber is just a logger specific ActiveSupport::Notifications subscriber, why doesn't RailsPerformance just bypass the LogSubscriber altogether and use ActiveSupport::Notifications directly?

If RailsPerformance can use the Notifications directly, would you be comfortable accepting an outside PR?

Contributor guide

Research direction
Study how ActiveSupport::Notifications works in Rails and how RailsPerformance currently hooks into LogSubscriber. Then design a simple integration that subscribes directly to the relevant notification events (e.g., process action.action controller, sql.active record) and captures performance data without depending on LogSubscriber. Consider edge cases like custom loggers. Implement a proof of concept and test with rails semantic logger.
Tech stack
ruby
Domain
backend
Issue type
Research
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RubyRails
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65